worker/server: update metrics on requeue #4461
Open
+69
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croissanne
force-pushed
the
bump-on-requeue
branch
from
241e9e5
to
4340f1e
Compare
When requeuing a job the next worker requesting the job would decrement pending counter, but the pending counter only ever got incremented once, when the job was first enqueued. Thus make sure to increment the pending counter when a job is requeued.
croissanne
force-pushed
the
bump-on-requeue
branch
from
4340f1e
to
2d0f3bd
Compare
schuellerf
approved these changes
Nov 6, 2024
| if requeued { | ||
| jobInfo, err := s.jobInfo(jobId, nil) | ||
| if err != nil { | ||
| return fmt.Errorf("error requeueing job: %w", err) |
There was a problem hiding this comment.
more like error getting job details for prometheus metrics
should we skip prometheus metrics here and try to continue, rather than fail?
although this will then probably fail some lines below…
There was a problem hiding this comment.
I think it's very unlikely that this call will fail if the job exists.
|
It's definitely possible to add unit tests, I'll do that. |
|
Sidenote - I think the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
worker/server: update metrics on requeue